Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Repo: Enable eslint-plugin-n in ESLint config #5063

Open
5 tasks done
JoshuaKGoldberg opened this issue Dec 28, 2023 · 0 comments · May be fixed by #5280
Open
5 tasks done

🛠 Repo: Enable eslint-plugin-n in ESLint config #5063

JoshuaKGoldberg opened this issue Dec 28, 2023 · 0 comments · May be fixed by #5280
Labels
area: repository tooling concerning ease of contribution core-team issues which must be handled by Mocha's core team status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Dec 28, 2023 •
edited
Loading

Tooling Suggestion Checklist

Overview

eslint-plugin-node is a devDependency in package.json:

mocha/package.json

Line 95 in 645469e

"eslint-plugin-node": "^11.1.0",

...but not used in the ESLint config.

The eslint-plugin-n plugin (the successor to eslint-plugin-node) is actually useful though. Let's enable from its recommended preset config?

Additional Info

The devDependency is being removed in #5060, but that's just because it's unused. This issue is suggesting adding it (well, eslint-plugin-n) back.
@JoshuaKGoldberg JoshuaKGoldberg added type: feature enhancement proposal area: repository tooling concerning ease of contribution labels Dec 28, 2023
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Dec 28, 2023
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Mocha can use your help with this one! core-team issues which must be handled by Mocha's core team type: chore generally involving deps, tooling, configuration, etc. and removed type: feature enhancement proposal labels Feb 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg linked a pull request Jan 2, 2025 that will close this issue
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: repository tooling concerning ease of contribution core-team issues which must be handled by Mocha's core team status: accepting prs Mocha can use your help with this one! type: chore generally involving deps, tooling, configuration, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: enabled eslint-plugin-n JoshuaKGoldberg/mocha
1 participant
@JoshuaKGoldberg