Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to "dynamics profile" #46

Open
chrbertsch opened this issue Jun 27, 2022 · 7 comments
Open

Changes to "dynamics profile" #46

chrbertsch opened this issue Jun 27, 2022 · 7 comments

Comments

@chrbertsch
Copy link
Contributor

Move from required to recommended:

  • Tunable Parameters
  • Store/Restore FMU State
  • Serialize/Deserialize FMU State
  • String Inputs/Outputs
  • Resizable Input/Output Arrays
  • Resizable Input/Output Arrays with Size-Dependencies
  • Resizable Parameter Arrays
  • Resizable Parameter Arrays with Size-Dependencies

Remove as the shall be supported anyway by all FMI3 FMUs:

  • New Integer Types
@andreas-junghanns
Copy link
Contributor

What about "Dynamics Controller Profile"? I think we should move the same features as above to recommended.

@KarlWernersson
Copy link

KarlWernersson commented Jun 27, 2022

Compared to all the other features that are required, why is directional derivative only recommended?

@KarlWernersson
Copy link

KarlWernersson commented Jun 27, 2022

To motivate: directional derivative, it is needed to efficiently solve algebraic loops which easily can occur when tightly connecting physical models in dynamic simulation.

edit.
Mainly for ME, although could also be sued for hybrid co-simulation during event mode

@pmai
Copy link
Collaborator

pmai commented Jun 27, 2022

Proposal from design meeting 2022-06-27:

  • Split into ME-specific and CS-specific Profile:
    • Drop Store/Restore for ME, add Directional Derivatives for ME as required, remove CS-specific features
    • Keep Store/Restore for CS as is,
  • Remove CS with Clocks here, should be enough in Dynamics Controller
  • Remove String I/O (-> binary I/O is likely enough)
  • Drop Resizable I/O Arrays with and without Size-Dependencies from Profile, might need a new profile for this specific use-case.
  • Drop Binary I/O

@MBlesken
Copy link

Proposal from design meeting 2022-06-27:

  • Remove String I/O (-> binary I/O is likely enough)

Good.

@chrbertsch
Copy link
Contributor Author

What about "Dynamics Controller Profile"? I think we should move the same features as above to recommended.

Hm. Currently the "Dynamics Controller Profile" mentions CS and ME specific features. Shouldn't we not better to decide for one of them?

@chrbertsch
Copy link
Contributor Author

Discussion:
Pierre: we can discuss whether to split into ME and CS or how to present this
Kaska: We should make resizable arrays recommended
And also new integer types.
Christian: Downgrade Store/Restore FMU State to recommended
Pierre: agree. You could backtrack. Remove Serialize/Deserialize FMU State"This should go into an optimization profile
Pierre: besides "clocked ME", the dynamics controller profile is similar to the dynamics profile. Does it make sense to have a separate profile for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants