Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to "Basic CS-Profile" #47

Open
andreas-junghanns opened this issue Jun 27, 2022 · 4 comments
Open

Changes to "Basic CS-Profile" #47

andreas-junghanns opened this issue Jun 27, 2022 · 4 comments

Comments

@andreas-junghanns
Copy link
Contributor

Move to optional:

  • resizable Inputs/Outputs : For most tools, changing the IO during runtime is impossible and we are calling this "Basic" which is, in my opinion, a contradiction
@MBlesken
Copy link

Move to optional:

  • resizable Inputs/Outputs : For most tools, changing the IO during runtime is impossible and we are calling this "Basic" which is, in my opinion, a contradiction

Not even optional, I think. Same goes for "Resizable Parameter Arrays"

@MBlesken
Copy link

Why "Binary FMUs for Desktop Platforms" and "... intended mainly for desktop simulation uses"? (typo by the way) - This is a very basic profile in general. It could be a first set of features to be supported on any platform that wants to start supporting FMUs. Let's include those, too.

@chrbertsch
Copy link
Contributor

Not even optional, I think. Same goes for "Resizable Parameter Arrays"

I would consider "Resizable Parameter Arrays" arrays as recommended.
Same for tunable parameters.

@chrbertsch
Copy link
Contributor

Discussion:
Kaska: We could have a basic CS, "middle" and advanced CS Profile
Pierre: if the basic only contains feature that are mandatory anyway, it is not necessary. We could rename "basic". This was referring more to the CS features such as early return.
Pierre: the intention for this Profile was perhaps: "normal CS is enough, but we need the arrays". For the "resizable" users perhaps underestimated the effort.
Christian: Shouldn'd we have a "simple array profile" and an "advanced arrays profile
Pierre/ Matthias: we should come from use cases
Christian: Arrays are wanted by almost all users and they are mandatory in FMI 3.0 anyway.
Pierre: We could still list it, because there might be other use cases.
Currently the profiles are not very regularized. E.g. there is no basic ME profile. Currently all the profiles are standalone, the more advanced profiles list again all the simple features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants