hiding value for boolean/null comparators #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aatrubilin
added a commit
to aatrubilin/django-advanced-filters
that referenced
this pull request
Apr 19, 2021
asfaltboy
reviewed
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little bit of a hack here, but does successfully hide the "value" input element when istrue, isfalse, and isnull operators are chosen. Since it technically populates the value of the element and then hides it, there will be a small annoyance if you switch it back to a field that requires input (you would see the value we stuck in there, i.e. - True/False). However, this seems less annoying than having to type "null" in the box when creating these fields.