Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in messages affected by Discord's new Signed Attachment CDN URLs #80

Open
inklesspen opened this issue Mar 24, 2024 · 4 comments
Labels
enhancement New feature or request todo 🗒️

Comments

@inklesspen
Copy link

https://discord.com/developers/docs/reference#signed-attachment-cdn-urls

Discord automatically updates the URLs in the client with new signatures so the images keep working, but of course the URLs in the mongo database do not get updated. When the expiration time on the URL is reached, the image will no longer work.

@sebkuip
Copy link
Member

sebkuip commented Mar 24, 2024

We already forsaw this coming. It's unfortunate but nothing really we can do as the logviewer is standalone and doesn't connect to discord to refresh the URLs.

A user removing the images from their DMs would also remove them from logviewer as well so it's nothing new anymore.

@inklesspen
Copy link
Author

It would be nice if there were some way to store them in mongo. Perhaps opt-in, with a ?saveimages command.

@lorenzo132
Copy link
Member

I personally think turning media files into base64 to save those in the mongodb would be the perfect solution for this.

However, i do believe that there should be a config to save the media or not into the mongo as it can take up alot of storage.

@lorenzo132
Copy link
Member

I personally think turning media files into base64 to save those in the mongodb would be the perfect solution for this.

However, i do believe that there should be a config to save the media or not into the mongo as it can take up alot of storage.

Note, this would be a breaking change.

@lorenzo132 lorenzo132 added enhancement New feature or request todo 🗒️ labels Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request todo 🗒️
Projects
None yet
Development

No branches or pull requests

3 participants