Should mf-types be committed to source control?

[nickhall]

Judging by the content and volatile nature of mf-types, I would assume that it should be left out of version control. But if you don't include it, then processes like running type checking in CI environments, which just operate on the plain source code, fail because modules for the imported remotes cannot be found.

What's the official guidance around this? Should I actually be committing these types?

[YanPes]

Some of the examples in the official repository contain the @mf-types dir.

There is no specific doc on best practices for DTS.

Currently, I commit them to bypass the issues on CI side.

@ScriptedAlchemy do you have some guidance here?

[nickhall]

Thank you both. I tried completely delaying the tsc call until after the webpack build completed but it looks like it's not working. I do see the "federated types extraction completed" logs but no @mf-types. I'll dig into it a bit more.

[YanPes]

Can you paste the error message? Also you were referring to ssh'ing to the dir. Are you running on docker?

[ScriptedAlchemy]

You need to ensure that types zip file that we emit is uploaded along with your build as well. If it's not then that might be the problem. No type is hosted on the internet for CI to grab vs locally if you have local server running and it can get it from there?

[nickhall]

Sorry all, forgot about this, but just wanted to update that everything is working fine now. I was able to track down my last remaining issues to an environment variable in the build system not being set correctly, leading to rspack silently failing to retrieve the remote types.

[YanPes]

@nickhall good to hear. You can mark the correct answers in the thread to help others searching in the archive. :-)