Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question/Answer Buttons Bug #28

Open
Nuan8 opened this issue Jul 12, 2014 · 1 comment
Open

Question/Answer Buttons Bug #28

Nuan8 opened this issue Jul 12, 2014 · 1 comment

Comments

@Nuan8
Copy link

Nuan8 commented Jul 12, 2014

This is actually one of the most important bugs I have found, so it somehow makes sense that i would report it last :-)

This is one of the first bugs a new user will face, that's why I consider it important. Its also not fixable by your typical user, as I will explain.

The buttons are on top of each other, which may not look wrong but, in the modx forums, they are side by side, which looks tons better. The one which is selected is also slightly wider than the other, which makes them look bad when stacked on top of each other.

In addition, there is supposed to be a picture of an arrow in the selected button, and this pic fails to appear, and there are errors when making the css file using compass related to this pic, the coding in the sass has some problem. Here are the errors:

WARNING on line 78 of /home/acj888/finalsass/_theme-settings.sass:
This selector doesn't have any properties and will not be rendered.
WARNING: 'selected.png' was not found (or cannot be read) in /home/acj888/finalsass/images/../../images/redo/icons
WARNING: 'selected.png' was not found (or cannot be read) in /home/acj888/finalsass/images/../../images/redo/icons
WARNING: 'selected.png' was not found (or cannot be read) in /home/acj888/finalsass/images/../../images/redo/icons
WARNING: 'selected.png' was not found (or cannot be read) in /home/acj888/finalsass/images/../../images/redo/icons

selected.png is the arrow picture.

The quick and easy solution to this is simply to take out the question/discussion functionality completely, by removing these buttons in the relevant file, which I believe is replyform.chunk.tpl. They do appear in a couple places in different templates (like new.tpl), but I never saw them once this chunk was altered. For me, the added functionality was not a requirement, so removing them completely solved the problem quickly and totally.

I tried to fix the picture problem in the sass, but failed. I did not attempt to fix the styling problem, to put the buttons in line.

Because they are broken, the buttons sometimes are hard to use, but they can be functional. However outside of MODX website, I don't believe anyone has gotten them completely fixed.

@MikeMichel
Copy link

+1
The buttons don't work in IE (11.x here). In Firefox and Chrome they do work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants