-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested MODX tags are not removed from extract correctly #20
Comments
Can confirm that it happens when a nested tag contains a |
I'm am experiencing this as well with our MODX site: https://ctmeter.nl/algemeen/zoekresultaten?search=downloads&id=319. As @hugopeek says, it happens when a nested tag contains a [[*...]] field. |
Maybe applying an output filter to the extract that strips out MODX tags can help? Kind of a tricky problem though. |
Thanks for the suggestion @Mark-H. I circumvented it a little by loading the introtext instead, if the extract contains the string =`:
Not an ideal / permanent solution though.. |
I'm having same issue, maybe adding an option to do a major cleanup of content? for example in model/simplesearch/simplesearch.class.php add in the createextract function, just after sanitize:
|
…-fix Pagination fix when using faceted search
When there are MODX tags in the result extract, they are filtered out, but if these tags contain other tags, e.g.
[[!foo? &blah=
[[!+ph? &blah=Value
]]&bar=
Value]]
, the parameters of the outer tag after the first]]
are shown in the extract, which results in the following to be visible to users in the search results:&bar=`Value
It does not happen in all cases, but I could reproduce it when the inner tag was either an uncached placeholder (
[[!+...]]
) or a ressource content field ([[*...]]
).The text was updated successfully, but these errors were encountered: