Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODExt Grid column editor tooltips are displayed even the config option editable is disabled #16507

Open
revocarne opened this issue Jan 5, 2024 · 0 comments
Labels
bug The issue in the code or project, which should be addressed.

Comments

@revocarne
Copy link

Bug report

Summary

In a grid, the icon pen is displayed even the config options editable is disabled.
It’s really unpleasant when for developing a CMP.

Step to reproduce

Still when disable the config options editable in a column.

Observed behavior

Easy to fix the "bug"
In the file "revolution/manager/assets/modext/widgets/core/modx.grid.js" line 475 and 1176

replace "if (c[i].editor) {"
by : "if (c[i].editor && c[i].editable) {"

Expected behavior

Environment

All

@revocarne revocarne added the bug The issue in the code or project, which should be addressed. label Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The issue in the code or project, which should be addressed.
Projects
None yet
Development

No branches or pull requests

1 participant