[3.1.0] No install button after downloading new package

[hugopeek]

Bug report

Summary

I'm not seeing the install button appear in the Package Management grid, after downloading a new package in MODX 3.1.0.

Step to reproduce

• Install MODX 3.1.0
• Install any package from package manager

Observed behavior

Expected behavior

Green install button should be present for packages that have not yet been installed.

Environment

MODX 3.1.0
Nginx
PHP 8.2
MariaDB 11.4

Firefox / Chromium both have this issue. No errors in console.

All is well in 3.0.6.

[BobRay]

This also happens if you uninstall just the current version. It shows as "not installed" but there's no "Install" button.

As far as I can tell, selecting "Reinstall" acts as if it's the "Install" button in all cases.

[halftrainedharry]

It looks like this problem was introduced with #16604.
When an package was not installed, the processor used to return null for the field "installed". Now it returns the value (Not Installed) instead.

Quite some code expects the value to be null to show the correct UI:

revolution/manager/assets/modext/workspace/package.grid.js

Lines 191 to 195 in 62b154a

	var state = (rec.installed !== null) ? ' installed' : ' not-installed';
	var values = { name: value, state: state, actions: null, message: null };
	var h = [];
	if(rec.installed !== null) {

revolution/core/src/Revolution/Processors/Workspace/Packages/GetList.php

Lines 117 to 118 in 62b154a

	$packageArray['iconaction'] = empty($packageArray['installed']) ? 'icon-install' : 'icon-uninstall';
	$packageArray['textaction'] = empty($packageArray['installed']) ? $this->modx->lexicon('install') : $this->modx->lexicon('uninstall');

---

To fix the issue, the function formatPackageDate() should only be called here, if the value is not null:

revolution/core/src/Revolution/Processors/Workspace/Packages/GetList.php

Lines 149 to 153 in 62b154a

	$packageArray['installed'] = $this->formatter->formatPackageDate(
	$packageArray['installed'],
	'installed',
	false
	);

[smg6511]

I'll take a look at this and post a fix later today. Surprised I didn't catch this while working on the referenced PR!

[smg6511]

If you search locally for packages and install a package, then do the same with a newer version of the package, it's not recognized as an upgrade.

This will have to be addressed in a different PR. When you mention the newer version being available, are you meaning available locally or remotely? Or does the same problem occur in both scenarios?

[opengeek]

Just locally. If you submit the new version to modx.com/extras and then download it, everything is fine. It only happens when you upload and search locally for the newer version.

Would you like me to file a second issue on it?

Please.

[BobRay]

Done #16676

[BobRay]

Closed #16676. Not an issue.

I tested this with a minimal package that has separate "Install" and "Update" sections in resolvers and validators. I can confirm that in 3.1.0, using "reinstall" works as it should with respect to resolvers and validators. For new packages, the "Install" section executes, for new versions that update the package, the "Update" section executes.