Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options are neither mutual exclusive nor given precedence #3

Open
vanHoesel opened this issue Oct 1, 2021 · 1 comment
Open

Options are neither mutual exclusive nor given precedence #3

vanHoesel opened this issue Oct 1, 2021 · 1 comment

Comments

@vanHoesel
Copy link
Contributor

One can easily add the options add multiple options, which might be weird to do so, I would agree. But it is not documented what order will be used.

Should we either check for multiple options that should be mutual exclusively set?
Should we allow multiple options and make env_key to be the final resort, being explicitly set ?

I tend to go for the first solution, because it is the most easy. But I was about to start on #2, where I need multiple ENV-vars to be an option, to be able to deprecate without breaking people their stuff.

@mohawk2
Copy link
Owner

mohawk2 commented Oct 3, 2021

I think you would need to spell out with examples (which could end up in the doc) about what would happen in each case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants