Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wilaya array needs a "strict" structure #15

Open
Fcmam5 opened this issue Sep 1, 2018 · 6 comments
Open

Wilaya array needs a "strict" structure #15

Fcmam5 opened this issue Sep 1, 2018 · 6 comments

Comments

@Fcmam5
Copy link
Contributor

Fcmam5 commented Sep 1, 2018

As Salam Alikum,
Please, can you suggest a strict structure/rules that contributors need to respect.
The current structure has some missing attributes in some "Wilayas" or their 'matricule' have only the number while others have ##- Wilaya name

Example (Node):

> w.Algeria.Wilayas.Wilaya.map((x,i) => x.matricule)
[ '01',
  '02',
  '03',
  '04',
  '05',
  '06',
  '07',
  '08- Bechar',
  '09- Blida',
  '10- Bouira',
  '11- Tamanrasset',
  '12- Tebessa',
  '13- Tlemcen',
  '14- Tiaret',
  '15- Tizi Ouzou',
  '16',
  '17- Djelfa',
...

And other fields doesn't exist for some 'wilaya':

> w.Algeria.Wilayas.Wilaya.map((x,i) => x.french)
[ 'Adrar',
  'Chlef',
  'Laghouat',
  'Oum El Bouaghi',
  'Batna',
  undefined,
  ' Biskra',
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
  'Alger',
  undefined,
  undefined,
  undefined,
  undefined,
  undefined,
...

Thank you very much for this initiative 😃, it helped me to create this modest snippet for a project.

@mohsenuss91
Copy link
Owner

@Fcmam5 Thanks for your contribution. How can I do that please!

@Fcmam5
Copy link
Contributor Author

Fcmam5 commented Dec 13, 2018

Just, add the structure that you're using for listing Wilayas/Baladiyahs in README or in the contributing guide so we make sure that each wilaya has those fields,for example french property is not present for 'Tizi Ouzou'.
And also matricule property is not "consistant", like sometmies it's like 31 or `31- Oran'.

Example:

{
               "matricule": "15- Tizi Ouzou",
               "Dairas": {
                  "Daira": {
                     "Baladiyahs": {
                        "Baladiyah": {}
                     }
                  }
               }
            },
            {
               "arabic": "الجزائر",
               "french": "Alger",
               "matricule": "16",
               "Dairas": {
                  "Daira": [
                     {
                        "arabic": "سيدي امحمد",
                        "french": "Sidi M'Hamed",
                        "Baladiyahs": {
                           "Baladiyah": [
                              {
                                 "arabic": "الجزائر الوسطى",
                                 "french": "Alger-Centre"
                              },
                              ...

@bensialih
Copy link
Contributor

Salam Abdeldjalil,

We've applied a stricter structure with typescript.
We are also adding geolocation to everything which I think its something you may be looking into.

If you need an explanation of how to apply the changes or a brief explanation please get in contact.

Abdel Hakim

@mohsenuss91
Copy link
Owner

Salam Abdeldjalil,

We've applied a stricter structure with typescript.
We are also adding geolocation to everything which I think its something you may be looking into.

If you need an explanation of how to apply the changes or a brief explanation please get in contact.

Abdel Hakim

Thank you I appreciate it @bensialih :)

@mansour1233
Copy link

رانا في 2023 الحاج ريقلو رواحكم

@mohsenuss91
Copy link
Owner

رانا في 2023 الحاج ريقلو رواحكم

يمكنك مساعدتنا والمساهمة في ذلك في أي وقت

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants