Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus theme: Return key in the comment field while modifying cancels the action #1559

Closed
cintek opened this issue Oct 27, 2023 · 5 comments
Closed

Focus theme: Return key in the comment field while modifying cancels the action #1559

cintek opened this issue Oct 27, 2023 · 5 comments

Comments

@cintek
Copy link
Contributor

cintek commented Oct 27, 2023

When you modify a wiki page, the comment field is focused and you press the return key you cancel the modification. I would expect that you apply the changes when you press that key.
@wagner-intevation
Copy link
Contributor

This is a bug of the new 'focus' theme (#1528 ), as it has a reverse order of input buttons:

  1. cancel -> default
  2. preview
  3. submit
    as opposed to the order in e.g. modernized:
  4. submit -> default
  5. preview
  6. cancel

wagner-intevation added a commit to wagner-intevation/moin that referenced this issue Nov 19, 2023
@wagner-intevation
focus, modify view: make submit button default
438db65 
reverse the order of button inputs (sumbit/OK first) in DOM, and thus
submit is the default on enter

to keep the order reversed when viewed (first cancel, then OK), reverse
the display with CSS

fixes moinwiki#1559
@wagner-intevation wagner-intevation mentioned this issue Nov 19, 2023
Merged
wagner-intevation added a commit to wagner-intevation/moin that referenced this issue Nov 20, 2023
@wagner-intevation
focus, modify view: make submit button default
db34fcd 
reverse the order of button inputs (sumbit/OK first) in DOM, and thus
submit is the default on enter

to keep the order reversed when viewed (first cancel, then OK), reverse
the display with CSS

fixes moinwiki#1559
@UlrichB22
Copy link
Collaborator

Thanks for your support.
Please close the issue when fixed by the latest commits.

@wagner-intevation
Copy link
Contributor

The issue will be automatically closed once the PR is merged into master.

@UlrichB22 UlrichB22 changed the title Return key in the comment field while modyfying cancels the action Focus theme: Return key in the comment field while modifying cancels the action Jan 19, 2024
@UlrichB22
Copy link
Collaborator

UlrichB22 commented Jan 19, 2024 •
edited
Loading

I would like to close this issue.
The mentioned fix is for repo cintek:new-theme.
@cintek, please try to merge. Thanks!

@cintek
Copy link
Contributor Author

cintek commented Jan 22, 2024

The fix is now merged into the repo.

@cintek cintek closed this as completed Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@UlrichB22 @cintek @wagner-intevation