Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To fix: The position balance and settlement balance didn’t update after settlement. #4009

Open
PhyuSinMyat8 opened this issue Sep 9, 2024 · 1 comment
Assignees
Labels
vNext vNext Platform Development (inline with RefArch)

Comments

@PhyuSinMyat8
Copy link

PhyuSinMyat8 commented Sep 9, 2024

Summary:

  • After the transaction, the position balance of payer and payee accounts updated correctly.
  • However, after the settlement process, the position balance and settlement balance didn’t update.
  • This settlement issue is occurring not only in admin UI but also in database.

Severity:
High

Priority:
Critical

Expected Behavior

  • After the settlement process, the settled amount should be deducted from the payer's settlement balance. Additionally, the position balance of the payer should be updated correctly.
  • After the settlement process, the settled amount should be added to the payee’s settlement balance. Additionally, the position balance of payee should be updated correctly.

Steps to Reproduce

  1. Firstly, record the position and settlement balance of payer and payee.
  2. Do transaction
  3. Record the position balance of payer and payee. [Position amount should be updated correctly after transaction.]
  4. Create matrix to settle the above transaction
  5. Close the matrix, Lock for settlement, Settle
  6. Check the position and settlement balance of payer and payee again

Specifications

Version: 0.5.42
Platform: Mojaloop
Type of testing: QA testing
Bug found/raised by: Phyu Sin Myat

Notes:

Severity when opened: High
Priority when opened: Critical

1.1. Payer's initial amount
image.png

1.2. Payee's initial amount
image.png

2. Transferred 20USD from pswallet to psmfi
Transfer ID (6e9eda40-be1d-4745-8b56-ef0021eded54)
image.png

3.1. Checked the position balance of payer [20USD updated with minus sign in position balance.]
image.png

3.2. Checked the position balance of payee [20USD updated with plus sign in position balance.]
image.png

4. Created matrix to settle the above transaction
image.png
image.png

5. Settled that matrix
image.png

6.1. Check the position and settlement balance of payer again
image.png

6.2. Check the position and settlement balance of payee again
image.png

In database after settlement

pswallet's USD position account
image.png

pswallet's USD settlement account
image.png

psmfi's USD position account
image.png

psmfi's USD settlement account
image.png

@PhyuSinMyat8 PhyuSinMyat8 added the vNext vNext Platform Development (inline with RefArch) label Sep 9, 2024
@elnyry-sam-k
Copy link
Member

updated severity and priority; if balances aren't updated it is critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vNext vNext Platform Development (inline with RefArch)
Projects
None yet
Development

No branches or pull requests

3 participants