-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove JFR files from sensitiveFileNameRegexes
#755
Comments
Do we still want to do this? |
Removing this would allow sharing JFR reports publicly on Mojira (though they are not shared very often). |
JFR reports also contain full paths on Windows, which usually include the Windows user name (which can be considered private information) |
With that, we could probably use some regex or something to replace the username with |
JFR files seem to use a custom binary file format, so we probably cannot easily redact information in it. However, I assume the number of Mojira issues where JFR files are attached is probably rather low, so maybe it is acceptable to just set these few issues to private? |
Yes, the amount of jfr files attached to bug reports has been very low, so in general I feel like a more sophisticated solution is not worth it. However, the current solution is still suboptimal. For example: JFR files were added to https://bugs.mojang.com/browse/MC-249136 by someone other than the reporter, and subsequently the bug report was set to private. This was confusing for the person attaching these bug reports, and also brings the potential for intentional sabotage. So I'm currently thinking that this either should be a manual task instead of automated, or we should prevent attaching jfr files by non-reporters outright. |
That is similar to #663, and as mentioned there in the comments it might also affect attachments which cause a report to be resolved as Invalid (not sure if that is still the case though). |
Currently JFR files are listed as sensitive files because they contained access tokens in the past:
arisa-kt/config/config.yml
Lines 194 to 195 in 743fbd2
However, we were told internally (where #751 had been mentioned as well), that the latest Minecraft versions do not include the access token in the JFR files anymore.
So in for example a month (to add some safety delay in case users still upload them from old versions) we should probably remove the JFR files from the sensitive file names list again.
The text was updated successfully, but these errors were encountered: