PIWOO-382 dont cache empty methods

mollie · Feb 22, 2024 · 656ee8f · 656ee8f
1 parent 04b0b3b
commit 656ee8f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Shared/Data.php b/src/Shared/Data.php
@@ -705,7 +705,7 @@ public function getAllAvailablePaymentMethods($useCache = true)
                 delete_transient($transient_id);
             }
             // No cache exists, call the API and cache the result
-            if ($methods === false) {
+            if (empty($methods)) {
                 if (!$apiKey) {
                     return [];
                 }
@@ -720,8 +720,8 @@ public function getAllAvailablePaymentMethods($useCache = true)
                 // $methods_cleaned is empty array when the API doesn't return any methods, cache the empty array
                 $methods = $methods_cleaned;
 
-                // Set new transients (as cache)
-                if ($useCache) {
+                // Set new transients (as cache) only if we have something in
+                if ($useCache && !empty($methods)) {
                     set_transient($transient_id, $methods, HOUR_IN_SECONDS);
                 }
             }