-
Notifications
You must be signed in to change notification settings - Fork 29
Create a card that lists all diseases related to the one being reviewed, and add to the overview display for a disease #241
Comments
We discussed with @kshefchek today that this would be feasible to tackle; however it would be best if there were a cleaner API call to make.
|
there was an outstanding question on whether to include implicit phenotypes in these counts @cmungall @pnrobinson your thoughts on this? |
Implicit phenotypes should (nearly) always be counted by algorithms. Whether or not to show all of them in a UI is another question that "depends". Could you describe the use case? |
it would just be for showing these counts in the mock up above, perhaps also some hover over that shows the phenotypes (@jmcmurry ?) I like the idea of counting implicit phenotypes as we already support this via jaccard sim. I was more worried people might see a large phenotype intersection count and click on the page and see a much smaller number and be confused. |
I mean that you may not want to show new nodes with implicit counts. I am not sure I understand the logic of the mockup, and it is not trivial to fine the best list of shared phenotypes for a larger list of diseases, that sounds like one of those nasty graph problems :-0. |
is this not just ranking jaccard sim scores? I may be under-thinking the problem |
or me. We have probably reached the limits of what can easily be discussed on issues, let's discuss at a huddle or zoom! |
From one disease see a preview of other diseases, whether they share:
The text was updated successfully, but these errors were encountered: