Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synonym Sync - better handling of conflicts between OMIM formerly and DOID abbreviations #762

Open
twhetzel opened this issue Jan 22, 2025 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@twhetzel
Copy link
Contributor

Based on the Mondo ../sparql/qc/general/qc-related-exact-synonym.sparql qc check errors here from running the Synonym Sync, the Synonym Sync (added case) should filter out any DOID synonym abbreviations with the scope exact if that same synonym matches an OMIM synonym abbreviation that is also tagged as formerly and has the scope related. In these cases, the synonym abbreviation scope of the OMIM formerly synonym abbreviation as related is correct.

@joeflack4
Copy link
Contributor

@twhetzel Hmm, this makes sense.

I'm going to hold off on this though, because mondo-ingest currently has no way of knowing which synonyms are "formerly" until we merge these:

@twhetzel
Copy link
Contributor Author

Sure, this issue does now raise the priority of those other OMIM ingest issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants