Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing types for plugin configuration #114

Open
jamesdanielgibbs opened this issue May 24, 2023 · 1 comment
Open

Missing types for plugin configuration #114

jamesdanielgibbs opened this issue May 24, 2023 · 1 comment

Comments

@jamesdanielgibbs
Copy link

This PR added native types which is much appreciated.

Sadly though, these types don't cover cases where specific functions need to be configured for the plugin. So the following results in Typescript compilation issues:

someSchema(mongooseAutoPopulate, { functions: ['findOne'] })

Screenshot 2023-05-24 at 21 00 50

Package versions

  • mongoose: 7.2.0
  • mongoose-autopopulate: 1.0.1
  • typescript: 5.0.4

Happy to throw a PR together so solve this issue - just want to find out if this is a me-only problem.

@vkarpov15
Copy link
Member

This seems like a legitimate issue, if you're willing to put in a PR that would be much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants