Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect order of serialized members in TkAnimNodeFrameData #159

Open
GaticusHax opened this issue Oct 13, 2019 · 0 comments
Open

Incorrect order of serialized members in TkAnimNodeFrameData #159

GaticusHax opened this issue Oct 13, 2019 · 0 comments
Assignees
Labels
fix A bug that is marked to be fixed.
Milestone

Comments

@GaticusHax
Copy link
Collaborator

GaticusHax commented Oct 13, 2019

In vanilla ANIM.MBIN files, the list data for the Translations and Scales members of the TkAnimNodeFrameData struct are reversed.

Although the members are defined in the order of: Rotations, Translations, Scales
The actual list data that is appended to the struct is ordered instead by: Rotations, Scales, Translations. Normally, the order of the list data will match the order of the member definitions. libMBIN does not handle this special case, which makes comparing files difficult as the order of the data is not the same.

Fix the serialization of the TkAnimNodeFrameData struct so that the list data is appended in the same order as the vanilla files.

@GaticusHax GaticusHax added the fix A bug that is marked to be fixed. label Oct 13, 2019
@GaticusHax GaticusHax added this to the Lossiness milestone Oct 13, 2019
@GaticusHax GaticusHax self-assigned this Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug that is marked to be fixed.
Projects
None yet
Development

No branches or pull requests

1 participant