Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3 octave scales shapes to renderScale #23

Open
Aduffy opened this issue Dec 23, 2020 · 4 comments
Open

Add 3 octave scales shapes to renderScale #23

Aduffy opened this issue Dec 23, 2020 · 4 comments

Comments

@Aduffy
Copy link

Aduffy commented Dec 23, 2020

Compliments on the new renderScale in .2! It is friggin brilliant. I implemented it to replace my code that was using your previous merged boxes examples.. SIGNIFICANTLY less code!

Do you have plans to add additional box shapes such as 3 octave scales ?

@moonwave99
Copy link
Owner

I think that more extended patterns are:

  1. hard to abstract;
  2. basically composition of existing ones.

I exclude an automatic generation for the moment.

A decent compromise for the time being is to merge consecutive boxes, filtering out the notes you do not need. For instance for a 3 octaves G major scale, you can glue:

  • G major (E shape) - G2 s6:f3 to G3 s4:f5;
  • G major (C shape) - A3 s4:f7 up to D5 s1:f10;
  • G major (G shape) - E5 s1:f12 to G5 s1:f15.

It shouldn't be complicated to write an helper that gets the box, filters out the notes lower than the threshold, and concatenates everything ^^


I aim at generating small experiments / playgrounds / exercises more than at having an all-inclusive library - mainly because I should be focusing more on playing guitar than implementing features here ^____________^

@Aduffy
Copy link
Author

Aduffy commented Dec 24, 2020

Fair enough.. and ditto.. I also should be focusing more on playing and less on coding!! :P

@Aduffy
Copy link
Author

Aduffy commented Jan 3, 2021

Are box for 3NPS and CAGED for Melodic Minor and Harmonic Minor scales on your road map at all?

image
image

@moonwave99
Copy link
Owner

Should not be much complicated because they are one position away from the existing TNPS patterns.
The only problem maybe the mode numbers, since they differ from the major scale and have quite exotic names.

I will check it somewhen in the next days, and if possible will implement it right away ^^

@moonwave99 moonwave99 changed the title Add 3 octive scales shapes to renderScale Add 3 octave scales shapes to renderScale Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants