-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3 octave scales shapes to renderScale #23
Comments
I think that more extended patterns are:
I exclude an automatic generation for the moment. A decent compromise for the time being is to merge consecutive boxes, filtering out the notes you do not need. For instance for a 3 octaves G major scale, you can glue:
It shouldn't be complicated to write an helper that gets the box, filters out the notes lower than the threshold, and concatenates everything ^^ I aim at generating small experiments / playgrounds / exercises more than at having an all-inclusive library - mainly because I should be focusing more on playing guitar than implementing features here ^____________^ |
Fair enough.. and ditto.. I also should be focusing more on playing and less on coding!! :P |
Should not be much complicated because they are one position away from the existing TNPS patterns. I will check it somewhen in the next days, and if possible will implement it right away ^^ |
Compliments on the new renderScale in .2! It is friggin brilliant. I implemented it to replace my code that was using your previous merged boxes examples.. SIGNIFICANTLY less code!
Do you have plans to add additional box shapes such as 3 octave scales ?
The text was updated successfully, but these errors were encountered: