Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give warning when passing 0-indexed dot strings #39

Open
Tails opened this issue Jan 26, 2022 · 0 comments
Open

Give warning when passing 0-indexed dot strings #39

Tails opened this issue Jan 26, 2022 · 0 comments

Comments

@Tails
Copy link

Tails commented Jan 26, 2022

My application generates 0-indexed fret/strings. Fretboard.js errored out on a line where it tried something like dots[string-1] which would go negative when passed a 0-indexed string. It would be good if it would validate string input/1-indexedness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant