Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing issues #87

Open
paulMery opened this issue Apr 5, 2023 · 4 comments
Open

Typing issues #87

paulMery opened this issue Apr 5, 2023 · 4 comments

Comments

@paulMery
Copy link
Contributor

paulMery commented Apr 5, 2023

1 TransferCreate type:

  • facilitatorFee, description, metadata should be optional.
  • in source and destination object: only paymentMethodID should be required.
    So it match the example here

    moov-node/lib/transfers.js

    Lines 259 to 280 in 5cb81da

    * @example
    * const moov = new Moov(...);
    * try {
    * const transfer = {
    * source: { paymentMethodID: "..." },
    * destination: { paymentMethodID: "..." },
    * amount: {
    * value: 3215, // $32.15
    * currency: "USD"
    * },
    * facilitatorFee: {
    * value: 8, // $0.8
    * currency: "USD"
    * },
    * description: "Yoga class"
    * };
    * const { transferID } = moov.transfers.create(transfer);
    * } catch (err) {
    * // ...
    * }
    *
    */

    as well as the API documentation

2 AccountCreate type:

  • metadata, termsOfService, foreignID, customerSupport, settings should be optional
  • mode : production | sandox is missing should be added as a required parameters as it's required in the API documentation.
  • in profile > IndividualProfile: Phone, Address, birthDateProvided, governmentIDProvided should be optional (with default values for the booleans)

3 API documentation

The api documentation (transfers/create section) is not matching the TransferCreate object. The transferID should be removed from the documentation as it's misleading or maybe we can create a transfer using another transfer but in that case I am not sure I understand.
image

Thanks ! 🙏

@paulMery
Copy link
Contributor Author

paulMery commented Apr 6, 2023

Also missing companyEntryDescription and originatingCompanyName in
TransferCreate > source > achDetails
Thanks

@AldoLopez
Copy link

bump

@houserx-jmcc
Copy link

houserx-jmcc commented Feb 29, 2024

Are there any status updates? This is impacting your paying customers still. @joshsadler

@Orrin-Manning
Copy link

This is still an issue that impacts the quality of the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants