Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement EMCOMP #6

Open
morganjwilliams opened this issue Jul 23, 2018 · 3 comments
Open

Reimplement EMCOMP #6

morganjwilliams opened this issue Jul 23, 2018 · 3 comments
Labels
enhancement New feature or request

Comments

@morganjwilliams
Copy link
Owner

morganjwilliams commented Jul 23, 2018 •
edited
Loading

Imputation using the expectation maximisation algorithm EMCOMP includes the assumption that data is below a certain threshold, which must be used as input. Consider reimplementing an expectation maximisation imputation algorithm in light of:

  • data is not missing at random, but is also typically not missing only due to being below detection (the expectation of the values is not necessarily 'below a threshold')
  • 'detection limits' are commonly not calculated, and rarely available as metatdata
@morganjwilliams
Copy link
Owner Author

Working version of EMCOMP is now included in pyrolite (2c04ec0, see docs).

@morganjwilliams
Copy link
Owner Author

The EMCOMP routine is currently unstable (trending towards inf, resulting in nonfinite covariance matrices).

@morganjwilliams morganjwilliams added bug Something isn't working enhancement New feature or request labels Mar 19, 2019
@morganjwilliams
Copy link
Owner Author

The current version of the algorithm is now stable. Potential enhancements may follow.

@morganjwilliams morganjwilliams removed the bug Something isn't working label Mar 23, 2019
@morganjwilliams morganjwilliams mentioned this issue Feb 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@morganjwilliams