Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bandwidth limit is broken when DecodeHeaders returns api.Running #589

Open
spacewander opened this issue Jun 17, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@spacewander
Copy link
Member

Bug

Captured in the test: https://github.com/mosn/htnn/actions/runs/9541395941/job/26295463705?pr=588
According to the debug log, the bandwidth limit filter is not invoked when DecodeHeaders returns api.Running.

Expected Behavior

No response

Actual Behavior

No response

Steps to Reproduce

Configure both bandwidthLimit plugin & a Go plugin which uses DecodeHeaders.

Reproducible Code

No response

Environment

  • HTNN version:
@spacewander spacewander added the bug Something isn't working label Jun 17, 2024
@spacewander spacewander self-assigned this Jun 17, 2024
@spacewander spacewander removed their assignment Jul 31, 2024
@spacewander
Copy link
Member Author

The bandwidth limit filter registers callbacks to control the decoding according to the token timer. So the same as Golang filter when DecodeHeaders returns api.Running. Their callbacks doesn't work well together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant