Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle for dynamic configuration #778

Open
seeflood opened this issue Sep 6, 2022 · 2 comments
Open

lifecycle for dynamic configuration #778

seeflood opened this issue Sep 6, 2022 · 2 comments
Labels
Milestone

Comments

@seeflood
Copy link
Member

seeflood commented Sep 6, 2022

What would you like to be added:
There's a problem when implementing the dynamic configuration feature. After agent got all the configuration via XDS, it tried to invoke the Layotto Lifecycle API but got an error:
image

To solve this problem, we need to use the health check hooks. The agent should invoke Lifecycle API after Layotto get started, but before the sidecar passes the readiness check

Why is this needed:

@seeflood seeflood added this to the v0.5 milestone Sep 28, 2022
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity in the last 30 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue or help wanted) or other activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 28, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

This issue has been automatically closed because it has not had activity in the last 37 days. If this issue is still valid, please ping a maintainer and ask them to label it as pinned, good first issue or help wanted. Thank you for your contributions.

@github-actions github-actions bot closed this as completed Nov 5, 2022
@seeflood seeflood added pinned and removed stale labels Nov 5, 2022
@seeflood seeflood reopened this Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant