Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SonarScan pipelines are failing on main #3110

Open
TSNoble opened this issue Nov 17, 2024 · 3 comments · May be fixed by #3115
Open

SonarScan pipelines are failing on main #3110

TSNoble opened this issue Nov 17, 2024 · 3 comments · May be fixed by #3115
Labels
bug Something isn't working

Comments

@TSNoble
Copy link
Contributor

TSNoble commented Nov 17, 2024

Description

See e.g. https://github.com/moveit/moveit2/actions/runs/11868931947/job/33078707644

I'd be happy to raise a fix (green jobs make me happy), but I'm not too familiar with SonarScan, so some guidance on whether --ignore-errors mismatch is the fix, or whether this requires deeper investigation would be appreciated!

ROS Distro

Humble

OS and version

SonarScan CI workflow

Source or binary build?

Source

If binary, which release version?

No response

If source, which branch?

rolling

Which RMW are you using?

None

Steps to Reproduce

Run a SonarScan job

Expected behavior

Presumably these should not fail

Actual behavior

They do

Backtrace or Console output

Capture coverage info
  geninfo: WARNING: /usr/include/c++/13/bits/basic_string.h:181: unexecuted block on non-branch line with non-zero hit count.  Use "geninfo --rc geninfo_unexecuted_blocks=1 to set count to zero.
  geninfo: ERROR: mismatched end line for _ZN56RobotTrajectoryTestFixture_ModifyFirstWaypointByPtr_Test8TestBodyEv at /home/runner/work/moveit2/moveit2/.work/target_ws/src/moveit2/moveit_core/robot_trajectory/test/test_robot_trajectory.cpp:361: 361 -> 366
  	(use "geninfo --ignore-errors mismatch ..." to bypass this error)
  Error: Process completed with exit code 1.
@TSNoble TSNoble added the bug Something isn't working label Nov 17, 2024
@sea-bass
Copy link
Contributor

sea-bass commented Nov 17, 2024

I was looking into this a little, and it seems like the argument to pass in is actually in this action: https://github.com/rhaschke/lcov-action/blob/7973632e3af4846e7f445a778e17d6c09b963f6a/action.sh#L40

@rhaschke -- do you know if this is something worth making configurable in your action, or whether the error is indicative of a different problem and we should consider an alternate solution to the recommendation?

@rhaschke
Copy link
Contributor

Will have a look.

@rhaschke rhaschke linked a pull request Nov 18, 2024 that will close this issue
@rhaschke
Copy link
Contributor

rhaschke commented Nov 18, 2024

Related to #2866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants