Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a read from dumps-only mode #154

Open
Standard8 opened this issue Apr 25, 2023 · 2 comments
Open

Add a read from dumps-only mode #154

Standard8 opened this issue Apr 25, 2023 · 2 comments
Assignees

Comments

@Standard8
Copy link
Contributor

For development, the search team method is to change the dumps locally, and then clear all data & restart.

This is generally fine, but runs the risk of the collections being updated from the server at some stage after the restart. To avoid this, we think it would be useful if the devtools could put the client into a dump-only mode which would enforce only loading from the dumps.

We could probably set the server url like we do for the in-tree tests.

@leplatrem leplatrem self-assigned this Apr 26, 2023
@leplatrem
Copy link
Contributor

This could potentially require changes on the client implementation, since we only load the dumps when the server URL is the prod server or when running tests (source). That condition was necessary since the data on the dev and stage servers do not match the dumps.

For the reference, this is the value we set:
user_pref("services.settings.server", "data:,#remote-settings-dummy/v1");

@leplatrem
Copy link
Contributor

leplatrem commented Apr 26, 2024

The typical scenario would be modifying the dump, testing it, modify again & restart to pick up the changes.
So I think there's two parts to this: 1) stopping the sync happening, 2) somehow clearing the database on each restart.
2) might be better if we also update the last modified (would we need to update the build's last modified as well?), though we'd probably need to find a way to script that in editors, so that it would happen automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants