Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix issue with less top sites shown than expected #23919

Open
data-sync-user opened this issue Dec 20, 2024 · 0 comments
Open

Need to fix issue with less top sites shown than expected #23919

data-sync-user opened this issue Dec 20, 2024 · 0 comments
Assignees

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Dec 20, 2024

See details here: https://github.com/mozilla-mobile/firefox-ios/pull/23918

Note: I notice a discrepancy in the previous PR in that in landscape we are showing 7 tiles instead of 8. Most likely due to my change in using environment.container.effectiveContentSize instead of view.size like the previous code. Will create a separate ticket to address this.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants