Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mozapkpublisher/update_apk_description.py: "commit option was not given. Transaction not committed." #114

Closed
sylvestre opened this issue Aug 20, 2018 · 3 comments

Comments

@sylvestre
Copy link
Collaborator

Using mozapkpublisher/update_apk_description.py requires a commit.
I am using the following syntax
cd ~/dev/mozilla/mozapkpublisher && . venv/bin/activate && mozapkpublisher/update_apk_description.py --package org.mozilla.klar --service-account [email protected] --credentials key.p12

Shows:

2018-08-20 16:05:10,570 - update_apk_description.py - INFO - Listing updated for 4 locale(s)
2018-08-20 16:05:10,570 - googleplay.py - WARNING - commit option was not given. Transaction not committed.

@JohanLorenzo
Copy link
Contributor

JohanLorenzo commented Aug 20, 2018

The command line argument --commit has become mandatory (if you want to publish something onto Google Play) since 5fbd518 . It prevents footguns. ./mozapkpublisher/update_apk_description.py --help documents what --commit does.

Please let me know if you'd prefer to not have to --commit on update_apk_description.py

@sylvestre
Copy link
Collaborator Author

nope, this is fine, thanks

@JohanLorenzo
Copy link
Contributor

Great 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants