Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to nextest and llvm-cov for unit tests and coverage #1651

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nshirley
Copy link
Collaborator

@nshirley nshirley commented Feb 26, 2025

Description

Describe these changes.

NOTE: We can only accept PRS with all commits signed. PRs that contain any unsigned commits will not be accepted and the PR must be resubmitted. If this is something you cannot provide, please disclose and a team member may duplicate the PR as signed for you (depending on availablity and priority. Thank you for your understanding and cooperation.)

This migrates unit test to use nextest and cargo-llvm-cov to support integration with the ete test pipeline

  • In addition to moving to nextest, the workflows now use the makefile test commands for consistency running locally vs. in ci
  • There are a few extra variables in the Makefile in preparation for integration tests reporting as well
  • I removed the --workspace flag for now, too, since it was causing issues with a failed build. It can be added back in once the underlying crate is fixed

Testing

How should reviewers test?

  • Unit tests should still pass in CI
  • There should also be an output/captured test results in CI

Issue(s)

Closes SYNC-4611.

@nshirley nshirley changed the title (chore): migrate to nextest and llvm-cov for unit tests and coverage chore: migrate to nextest and llvm-cov for unit tests and coverage Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant