Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] recommend https://github.com/Centril/rust-safe annotations for unsafe code? #17

Open
g-k opened this issue Jul 5, 2019 · 1 comment

Comments

@g-k
Copy link
Contributor

g-k commented Jul 5, 2019

For the rust guidelines, we have - [ ] If you must use 'unsafe', include a comment explaining why you believe its use is sound and its behavior is correct and well defined and there's a crate for that now: https://github.com/Centril/rust-safe#getting-started

So pending some basic review of that crate, we could change that item to "include a rust-safe annotation with a reason or comment explaining why you believe its use is sound and its behavior is correct and well defined"

Thoughts @psiinon?

@bbangert I believe you originally recommended adding the comments for unsafe code have you tried rust-safe?

@bbangert
Copy link
Member

bbangert commented Jul 7, 2019

I have not tried it, so I don't have any meaningful input on that. Maybe @pjenvey or Donovan (I don't know his github handle) have more input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants