[Bug]: approval of an appeal from Cinder for awaiting review versions in rev tools

[ioanarusiczki]

What happened?

From #15278 (comment)

Scenario is:

1. an awaiting review version is sent to Cinder Legal queue (no abuse reports attached)
2. from here the version is disabled with a policy
3. developer is sending the appeal
4. the appeal lands in T&S Escalation queue
5. Decision is Approve

What did you expect to happen?

An email is sent to the developer that the version is available and content has been reinstated
Version is still in awaiting review , no longer flagged for review in rev tools
actually versions are flagged for HR again and available in the manual review queue

example: https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-unlisted/635869

(As workaround: this would also require a manual approval from rev tools and would send a second email)

Another example:
https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635868
https://stage.cinder.nonprod.webservices.mozgcp.net/job/9fbece09-bcc8-4561-af4a-8b1e975fa424

Is there an existing issue for this?

• I have searched the existing issues

┆Issue is synchronized with this Jira Task

[KevinMind]

@ioanarusiczki can you separate what you expected to happen from what actually happened in this case?

[ioanarusiczki]

Maybe awaiting review versions should not go to Cinder? Normally, the cinder approval should approve the awaiting review version in rev tools? Or if the current flow is not so bad, maybe not 🤦‍♀️

[diox]

So the bug is that despite the approval in Cinder following the appeal, the version is still in the reviewer queue. But this is a weird edge case, cause the version was never public, right ? So it does make sense for it to go back to reviewers IMHO, the legal side of it was eventually cleared after approving following the appeal, but the code hasn't been reviewed yet.

[wagnerand]

Ah right, if the version is still pending review, it should be in the queue for that reason.

[ioanarusiczki]

@diox

I've done some research around on this scenario with

1. an already signed version -> then it works just fine , version is disabled/re-enabled so the email is accurate
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/635988

2. an appeal sent by the developer for an awaiting review version and moderated exclusively from rev tools. Version is rejected, developer appeal sent, flags it again for moderation. It can be unrejected and approved + the appeal checked. This is working because unreject is silent (won't send any emails)
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635991

3. the add-on has already an approved version then an awaiting review
   https://addons-dev.allizom.org/en-US/developers/addon/an-approved-an-awaiting-review/versions
   This is a bit different compared to a first version in awaiting review because after the approval of the appeal from T&S Escalations queue the signed version becomes available again so the email sent would be accurate because the add-on is listed. The awaiting review version is now flagged for HR awaiting for moderation in rev tools. Which does not sound bad.
   https://reviewers.addons-dev.allizom.org/en-US/reviewers/review/635987

4. final attempt when there's only a first awaiting review version : trying to escalate developer's appeal back to rev tools

Here I failed in my first attempt. I sent it from T&S Escalations to Legal Escalation but I've no possibility to escalate back to rev tools from here

But I could escalate the appeal from T&S Escalations with a policy such as "closed user group" . Appeal went back to rev tools and it is now flagged for HR. It would still require force enable + approve and this means it's again 2 emails sent, the one above and then the one about the version being approved.

https://reviewers.addons-dev.allizom.org/en-US/reviewers/review-listed/635990