Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual thunderbird tinderbox test_case is wrong #238

Closed
Nebelhom opened this issue Jan 22, 2015 · 5 comments
Closed

Manual thunderbird tinderbox test_case is wrong #238

Nebelhom opened this issue Jan 22, 2015 · 5 comments

Comments

@Nebelhom
Copy link
Collaborator

I just noticed earlier that the following manual test case in test_cases.md is wrong

mozdownload -a thunderbird -t tinderbox -p linux --branch=mozilla-central --extension=txt

It should be --branch=comm-central

Unless we are implementing this test_case any time soon, I would say this is a great first patch for a newcomer.

@whimboo
Copy link
Contributor

whimboo commented Jan 29, 2015

Agreed. Marking as a mentored issue then.

@andreheringer
Copy link
Contributor

I maybe be that newcomer Nebelhom is referring to. If this issue still needs attention.

@whimboo
Copy link
Contributor

whimboo commented Apr 8, 2019

Oh, this was actually done via PR #402. Looks like we simply forgot to mark this issue as closed.

@andreheringer if you are still interested to help let me know and we can certainly find another spot to get you started.

@whimboo whimboo closed this as completed Apr 8, 2019
@andreheringer
Copy link
Contributor

@whimboo oh ok. Sure I would love to help, have 2 years of experience working in python but never contribute to open source. Yet I hope to be helpful.

@whimboo
Copy link
Contributor

whimboo commented Apr 15, 2019

@andreheringer this is great. Would you mind having a look at issue #550 which just needs some tests to be disabled? It's an easy fix, and will help you to get into the project, and how to run the tests. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants