From a5d5b2ba19c5dee59cb462bf3d4ccffa3eedb3c7 Mon Sep 17 00:00:00 2001 From: Max Inden Date: Sun, 26 Jan 2025 12:53:15 +0100 Subject: [PATCH] test(transport/vn): allow dropped_rx of 1 (#2363) `compatible_upgrade_large_initial` tests whether Neqo can handle an ACK using QUIC version Y on a connection that ends up using QUIC version X. https://github.com/mozilla/neqo/pull/2228 changed the test, asserting that the server will drop 2 instead of 1 packet. This spuriosly fails on CI: https://github.com/mozilla/neqo/actions/runs/12796212878/job/35675377711?pr=2295 This commit allows both 1 and 2 packets dropped by the server. --- neqo-transport/src/connection/tests/vn.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neqo-transport/src/connection/tests/vn.rs b/neqo-transport/src/connection/tests/vn.rs index 60fafd56aa..2c9d5a5a82 100644 --- a/neqo-transport/src/connection/tests/vn.rs +++ b/neqo-transport/src/connection/tests/vn.rs @@ -251,7 +251,7 @@ fn compatible_upgrade_large_initial() { assert_eq!(server.version(), Version::Version2); // Only handshake padding is "dropped". assert_eq!(client.stats().dropped_rx, 1); - assert_eq!(server.stats().dropped_rx, 2); + assert!(matches!(server.stats().dropped_rx, 1 | 2)); } /// A server that supports versions 1 and 2 might prefer version 1 and that's OK.