Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add pre-commit hook checks to prevent ruff lint failures #268

Closed
1 of 3 tasks
paulooctavio opened this issue Oct 3, 2024 · 1 comment
Closed
1 of 3 tasks

ENH: Add pre-commit hook checks to prevent ruff lint failures #268

paulooctavio opened this issue Oct 3, 2024 · 1 comment
Assignees
@paulooctavio

Comments

@paulooctavio
Copy link
Contributor

Feature Type

  • Adding new functionality to quinn

  • Changing existing functionality in quinn

  • Removing existing functionality in quinn

Problem Description

Pull requests, like PR #265, can be merged and still break the build, for instance, by failing ruff lint.

Feature Description

We should add a pre-commit check similar to the hooks used in the chispa project.

Additional Context

No response
@paulooctavio
Copy link
Contributor Author

take

@paulooctavio paulooctavio changed the title ENH: Add pre-commit hook checks to prevent build failures ENH: Add pre-commit hook checks to prevent ruff lint failures Oct 26, 2024
This was referenced Oct 26, 2024
Closed
Open
@paulooctavio paulooctavio closed this as not planned Won't fix, can't repro, duplicate, stale Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulooctavio paulooctavio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paulooctavio