Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please write unit tests #26

Open
theodorDiaconu opened this issue Feb 7, 2018 · 3 comments
Open

Please write unit tests #26

theodorDiaconu opened this issue Feb 7, 2018 · 3 comments
Labels
help wanted

Comments

@theodorDiaconu
Copy link

No description provided.

@theodorDiaconu theodorDiaconu changed the title Please write unit tests :) Please write unit tests Feb 7, 2018
@msavin
Copy link
Owner

msavin commented Feb 7, 2018

Glad to see your interest in the package :)

I'm planning to do a v3 soon-ish - want to stabilize it before writing tests.

PS: I have zero experience writing tests - would appreciate if someone can help :)

@theodorDiaconu
Copy link
Author

@msavin you stabilize it by writing tests!

@msavin
Copy link
Owner

msavin commented Feb 7, 2018

I've seen some crazy things man.. I was reviewing code before that passed tests but did not run 😅

By stabilize - I also mean the API - it might need some changes. It would be great to hear your critique of the setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theodorDiaconu @msavin