Rework coal alloy furnace ABM a bit #400
Open
+32
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
S-S-X
commented
Feb 9, 2025
Comment on lines
-192
to
193
| local fuel = nil | ||
| local afterfuel | ||
| local fuellist = inv:get_list("fuel") | ||
|
|
||
| if fuellist then | ||
| fuel, afterfuel = minetest.get_craft_result({method = "fuel", width = 1, items = fuellist}) | ||
| end | ||
| local fuel, afterfuel = minetest.get_craft_result({method = "fuel", width = 1, items = fuellist}) | ||
|
|
||
| if fuel.time <= 0 then |
There was a problem hiding this comment.
Kind of seems too simple to me, did I overlook something?
Reasoning: in case if fuellist expression fails then it would anyway crash on if fuel.time <= 0 so basically this shouldn't really affect outcome and is basically just cleanup.
I believe this should be fine and there's other issues unrelated to this change in case it actually crashes.
Click for detailed source code test coverage reportTest coverage report for Technic CNC 87.49% in 11/14 files:Test coverage report for technic chests 44.99% in 6/6 files:Test coverage report for technic 67.06% in 97/98 files:Raw test runner output for geeks:CNC: Chests: Technic: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #398
For API
technic.get_recipe(method, items)I'd rather leave it as is and not try to check every possible user mistake there but rather specify that arguments must be of correct type and contain correct information.This old compatibility shim has been there for over 11 years already and now it has been removed.
Additionally we've already dropped some similar compatibility shims that were not even this old.