Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a BetterTabActivity #29

Open
erizzo opened this issue Apr 28, 2011 · 2 comments
Open

Create a BetterTabActivity #29

erizzo opened this issue Apr 28, 2011 · 2 comments

Comments

@erizzo
Copy link

erizzo commented Apr 28, 2011

One base Android Activity that isn't included in the DroidFu extensions is TabActivity. After a quick glance, it looks like the code from BetterDefaultActivity could probably be copied into a new class like:
BetterTabActivity extends TabActivity implements BetterActivity {
...
}

I think it would be a 2-minute addition, not including testing of course.
I was going to do this in my own package for an app I'm currently working on, but BetterActivityHelper.handleApplicationClosing() is not public so I can't call it.

@mttkay
Copy link
Owner

mttkay commented Apr 29, 2011

yes, makes sense. Can you create and test it in your app and send me a pull request if everything checks out? I'd merge it back into master then

@erizzo
Copy link
Author

erizzo commented Apr 29, 2011

I'm git-inept; if I just send the one .java file would that be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants