Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem safebrowsing and Google #257

Open
freeburn12 opened this issue May 24, 2024 · 8 comments
Open

Problem safebrowsing and Google #257

freeburn12 opened this issue May 24, 2024 · 8 comments
Labels
Milestone

Comments

@freeburn12
Copy link

freeburn12 commented May 24, 2024

Hi very good job for your fork for free all privacy

Why you haven't deleted all Google and safebrowsing lines:

browser.safebrowsing.provider.google.advisoryURL
browser.safebrowsing.provider.google.lists
browser.safebrowsing.provider.google.reportURL
browser.safebrowsing.provider.google4.advisoryURL
browser.safebrowsing.provider.google4.dataSharingURL
browser.safebrowsing.provider.google4.lists
browser.safebrowsing.provider.google4.reportURL
browser.safebrowsing.provider.google.reportMalwareMistakeURL
browser.safebrowsing.provider.google.reportPhishMistakeURL

And you have forgot Mozilla safebrowsing line:

browser.safebrowsing.provider.mozilla.lists
browser.safebrowsing.reportPhishURL

-And yet you have good erase this line

browser.safebrowsing.provider.google.gethashURL
browser.safebrowsing.provider.google4.dataSharingURL
browser.safebrowsing.provider.google4.gethashURL
browser.safebrowsing.provider.mozilla.gethashURL
browser.safebrowsing.provider.mozilla.updateURL

And other For Better confidentiality
gogol mull

Please fix for the next update
Thanks

@Thorin-Oakenpants
Copy link

Thorin-Oakenpants commented May 27, 2024

tor browser and mullvad browser do not utilize google safebrowsing - the prefs are meaningless

@ruihildt +1 close unless you want to add something to the faq

@freeburn12
Copy link
Author

Thanks for your response.

So you could remove these lines to avoid confusion.

Thanks

@freeburn12
Copy link
Author

So How do you change the internal prefs and settings for an enterprise deployment, without using a .cfg file or policies.json ?

@Thorin-Oakenpants
Copy link

So you could remove these lines to avoid confusion

why are you in about:config (rhetorical question)? And no, because it adds complexity and code and rebasing and etc etc where it is not needed

cc: @PieroV who can maybe explain more

@PieroV
Copy link
Collaborator

PieroV commented May 27, 2024

Why you haven't deleted all Google and safebrowsing lines:

Because they aren't active.
They're behind browser.safebrowsing.*.enabled, which are set to false.
Also, even if we wanted to use them, we'd have to have an API key which we don't.

I'd be okay with accepting a MR to set them to empty strings, but realistically once the .enabled are false it's enough for us.

@freeburn12
Copy link
Author

You could remove these lines to avoid confusion for new users who want to trust you as you say, not like firefox who says that "his priority is our privacy outside GAFAM", while they let the google safebrowsing activate, telemetry ...

Even if me I know that they are disabled in your fork. A little effort on this would be a must for many people. Please understand it. It's your goal and job.
Thanks

@PieroV
Copy link
Collaborator

PieroV commented May 29, 2024

Fair. I created an upstream issue.

@freeburn12
Copy link
Author

I understand technically, but it is necessary, to be in line with your principles and the trust we have in you. Thank you for your attention

@ruihildt ruihildt added this to the 14.0 milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

4 participants