Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial window de-maximizes when using Only Show on New Tab #270

Open
eiqnepm opened this issue Jun 22, 2024 · 7 comments
Open

Initial window de-maximizes when using Only Show on New Tab #270

eiqnepm opened this issue Jun 22, 2024 · 7 comments
Labels
bug Something isn't working ui/ux

Comments

@eiqnepm
Copy link

eiqnepm commented Jun 22, 2024

Tools > Settings > General > Window size > Reuse last window size when opening a new window
View > Toolbars > Bookmarks Toolbar > Only Show on New Tab

When opening Mullvad Browser and visiting a site for the first time the window will minimize.

@Thorin-Oakenpants
Copy link

worksforme on windows. What is your OS?

@Thorin-Oakenpants
Copy link

Thorin-Oakenpants commented Jun 24, 2024

What I do note is that on the first site visit the window size snaps to letterboxing dimensions - which may be due to https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192

i.e we shouldn't resize the window if remember last size is enabled - edit: maybe/maybe not = we need to think thru the logic

cc @hackademix

@hackademix
Copy link
Collaborator

hackademix commented Jun 25, 2024

By "minimize" you mean literally disappear in the dock / apps bar or whatever, or rather scale back to a slightly smaller size making up for the disappearing toolbar (which would be expected, even though debatable, per https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192 ?)

@eiqnepm
Copy link
Author

eiqnepm commented Jun 25, 2024

By "minimize" you mean literally disappear in the dock / apps bar or whatever, or rather scale back to a slightly smaller size making up for the disappearing toolbar (which would be expected, even though debatable, per https://gitlab.torproject.org/tpo/applications/tor-browser/-/issues/42192?)

On Windows the window goes from being fullscreen to a smaller sized floating window. Not F11 fullscreen, just maximized window.

@hackademix
Copy link
Collaborator

On Windows the window goes from being fullscreen to a smaller sized floating window. Not F11 fullscreen, just maximized window.

OK, I can reproduce it on the Tor Browser as well. We probably don't want snapping down letterboxing size if the window is maximized. Open an issue on our tor tracker, thanks.

@Thorin-Oakenpants
Copy link

@ruihildt ruihildt added ui/ux bug Something isn't working fingerprinting and removed fingerprinting labels Jun 25, 2024
@Thorin-Oakenpants
Copy link

title is misleading - it's "initial window de-maximizes when..."

@ruihildt ruihildt changed the title Initial window minimizing when using Only Show on New Tab Initial window de-maximizes when using Only Show on New Tab Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux
Projects
Status: Planned
Development

No branches or pull requests

4 participants