Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide on where the resampling shall take place #3

Open
TonioF opened this issue Feb 16, 2018 · 3 comments
Open

Decide on where the resampling shall take place #3

TonioF opened this issue Feb 16, 2018 · 3 comments
Assignees
Milestone

Comments

@TonioF
Copy link
Collaborator

TonioF commented Feb 16, 2018

It must be clear when, where and how the data is brought to the same grid. The simplest approach is to resample everything before it is passed to the inference engine. When data from different sources is combined though, the inference engine might want to decide on how this combination is done not only spectrally/thematically, but also spatially.

If the resampling is done outside of the inference engine, we might consider adding a new component for this.

@jgomezdans
Copy link
Collaborator

The input observations, observations mask & associated uncertainties need to be resampled to match the state mask. For S2 (and similarly for S1), this is done here. The actual function that does the resampling could be hosted elsewhere (I just never figure out where).

@TonioF
Copy link
Collaborator Author

TonioF commented Feb 19, 2018

I have already put that function into multiply-core. That is the place where we should put shared code.

When you say that you resample it to the state mask, is that because you assume the state mask has the spatial extent and resolution specified by the user? I am asking because it might happen that we have to resample the state mask, too, doesn't it? (if it is provided as vector data, we first have to bring it to a grid, so we can take the requested one right away, of course)

@NPounder
Copy link

Discussion continues here:
multiply-org/multiply-core#8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants