Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add querying endpoint #1

Open
mupraj10 opened this issue Oct 2, 2019 · 3 comments · May be fixed by #21
Open

Add querying endpoint #1

mupraj10 opened this issue Oct 2, 2019 · 3 comments · May be fixed by #21
Labels
good first issue

Comments

@mupraj10
Copy link
Owner

mupraj10 commented Oct 2, 2019 •
edited
Loading

A new API endpoint to allow users to get an array with all quotes when a query string of a certain word or phrase is passed.
Please reference this Issue in your PR
@thedeany
Copy link

thedeany commented Oct 2, 2019

I'd like to work on this! Should it match whole words or substrings?

@mupraj10
Copy link
Owner Author

mupraj10 commented Oct 2, 2019 •
edited
Loading

awesome! let's match on whole words, what do you think?

@thedeany
Copy link

thedeany commented Oct 2, 2019

That would make sense! I could see it going both ways though, which is why I wanted to clarify. I’ll get this done tonight after work!

@thedeany thedeany linked a pull request Oct 3, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keyword search endpoint thedeany/leslie-knope-quotes
2 participants
@thedeany @mupraj10