Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deezer importer: Issues #569

Open
MaxEtMoritz opened this issue Aug 23, 2024 · 0 comments
Open

Deezer importer: Issues #569

MaxEtMoritz opened this issue Aug 23, 2024 · 0 comments

Comments

@MaxEtMoritz
Copy link

Hi, Thank you for your work in building all these import scripts.

Today while using the Deezer importer i came across two issues:

  1. The importer only imports the first 25 tracks of an album, not the complete one. Probably a pagination issue?
  2. Only the main artist is imported, additional artists are missing.

I looked at what Deezer returns from the API, and to resolve 1., a check if nb_tracks is greater than the length of the tracks array needs to be done. if this is the case, the next tracks need to be requested from https://api.deezer.com/album/<album_id>/tracks?index=<track array length> (by the way, this track list also lists track ISRCs that could be submitted to MB).

For 2., not even the dedicated track list includes all artists (unless there's a parameter that can be set to include those. Don't have a deezer account that would be necessary to check the official api docs). Requesting each individual track would include those artists.

Unfortunately i do not have the time to assemble a PR that resolves 1. since i'm going on vacation tomorrow.

MaxEtMoritz added a commit to MaxEtMoritz/musicbrainz-userscripts that referenced this issue Sep 9, 2024
murdos#569 partial fix (first bullet point)
additional improvements:
- correctly submit multi-medium releases
- track ISRCs are available for submission (not implemented yet)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant