You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi, Thank you for your work in building all these import scripts.
Today while using the Deezer importer i came across two issues:
The importer only imports the first 25 tracks of an album, not the complete one. Probably a pagination issue?
Only the main artist is imported, additional artists are missing.
I looked at what Deezer returns from the API, and to resolve 1., a check if nb_tracks is greater than the length of the tracks array needs to be done. if this is the case, the next tracks need to be requested from https://api.deezer.com/album/<album_id>/tracks?index=<track array length> (by the way, this track list also lists track ISRCs that could be submitted to MB).
For 2., not even the dedicated track list includes all artists (unless there's a parameter that can be set to include those. Don't have a deezer account that would be necessary to check the official api docs). Requesting each individual track would include those artists.
Unfortunately i do not have the time to assemble a PR that resolves 1. since i'm going on vacation tomorrow.
The text was updated successfully, but these errors were encountered:
MaxEtMoritz
added a commit
to MaxEtMoritz/musicbrainz-userscripts
that referenced
this issue
Sep 9, 2024
Hi, Thank you for your work in building all these import scripts.
Today while using the Deezer importer i came across two issues:
I looked at what Deezer returns from the API, and to resolve 1., a check if
nb_tracks
is greater than the length of thetracks
array needs to be done. if this is the case, the next tracks need to be requested fromhttps://api.deezer.com/album/<album_id>/tracks?index=<track array length>
(by the way, this track list also lists track ISRCs that could be submitted to MB).For 2., not even the dedicated track list includes all artists (unless there's a parameter that can be set to include those. Don't have a deezer account that would be necessary to check the official api docs). Requesting each individual track would include those artists.
Unfortunately i do not have the time to assemble a PR that resolves 1. since i'm going on vacation tomorrow.
The text was updated successfully, but these errors were encountered: