Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve build process #14

Open
alwaysblank opened this issue Jul 30, 2020 · 0 comments
Open

Improve build process #14

alwaysblank opened this issue Jul 30, 2020 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@alwaysblank
Copy link
Collaborator

The current release build process generates a compiled file that works fine, but if imported via webpack (or mix) causes a warning like this to be thrown on build:

WARNING in ./node_modules/@murmurcreative/drawer/dist/index.js 1:292-296
Critical dependency: the request of a dependency is an expression
 @ ./resources/assets/scripts/modules/primary-nav.js
 @ ./resources/assets/scripts/app.js
 @ multi ./resources/assets/scripts/app.js ./resources/assets/styles/app.css ./resources/assets/styles/editor.css

This error seems to be a result of how Parcel compiles things down to a single file, using it's own require functionality, which webpack then complains about.

So far as I can tell this has no negative effects (beyond throwing this error) but the intent for this package is for it to be simple, easy, and understandable, and arcane errors are counter to those goals.

Potential solutions:

  1. Don't use parcel to build
  2. Don't worry about compiling into a single file

Since I'd like to generate a single artifact people can import and then go, I'm leaning toward option 1, much as I like Parcel.

@alwaysblank alwaysblank added the bug Something isn't working label Jul 30, 2020
@alwaysblank alwaysblank added this to the 2.0 milestone Jul 30, 2020
@alwaysblank alwaysblank self-assigned this Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant