Handle missing file in playlist more gracefully

[msknight]

I thought I'd bring this to someone's attention. I'm on the latest versions available. I had a file that was listed in a playlist, but the file name changed on SMB share, so the file in the playlist was not present any more. It didn't handle the situation gracefully.

It threw a code error in the logs and stopped playing...

FileNotFoundError: [Errno 2] No such file or directory: '/tmp/filesystem_smb--SXyHxKUW/j/Joe Sample/New Places New Faces - Joe Sample.ogg'
2025-01-22 12:50:32.978 ERROR (MainThread) [music_assistant] Error doing task: Task exception was never retrieved
Traceback (most recent call last):
  File "/app/venv/lib/python3.12/site-packages/music_assistant/controllers/player_queues.py", line 1404, in _enqueue_next
    next_item = await self.load_next_item(queue.queue_id, queue.current_index)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/venv/lib/python3.12/site-packages/music_assistant/controllers/player_queues.py", line 1109, in load_next_item
    queue_item.streamdetails = await get_stream_details(
                               ^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/venv/lib/python3.12/site-packages/music_assistant/helpers/audio.py", line 230, in get_stream_details
    streamdetails: StreamDetails = await music_prov.get_stream_details(prov_media.item_id)
                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/venv/lib/python3.12/site-packages/music_assistant/providers/filesystem_local/__init__.py", line 644, in get_stream_details
    file_item = await self.resolve(item_id)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/venv/lib/python3.12/site-packages/music_assistant/providers/filesystem_local/__init__.py", line 1117, in resolve
    return await asyncio.to_thread(_create_item)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/asyncio/threads.py", line 25, in to_thread
    return await loop.run_in_executor(None, func_call)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.12/concurrent/futures/thread.py", line 58, in run
    result = self.fn(*self.args, **self.kwargs)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/venv/lib/python3.12/site-packages/music_assistant/providers/filesystem_local/__init__.py", line 1105, in _create_item
    stat = os.stat(absolute_path, follow_symlinks=False)

[OzGav]

That is normal. The file will be found again on the next scan but your playlist would need to be fixed.

[msknight]

Understood... but the code throws an error and stops rather than handle it gracefully and, say, skips the track.

[OzGav]

Ok I have changed this to a feature request