From d7202e21a65a038c4fe580dce617512715ec5fc1 Mon Sep 17 00:00:00 2001
From: alex <alex@slab.org>
Date: Thu, 26 Dec 2019 11:47:34 +0000
Subject: [PATCH] stop doubling of events inferred by parameters if midicmd is
 set

---
 classes/DirtEventTypes.sc | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)

diff --git a/classes/DirtEventTypes.sc b/classes/DirtEventTypes.sc
index 1842c499..6f9c3717 100644
--- a/classes/DirtEventTypes.sc
+++ b/classes/DirtEventTypes.sc
@@ -41,7 +41,7 @@ DirtEventTypes {
 
 				var freq, lag, sustain;
 				var args, midiout, hasGate, midicmd, latency, chan;
-				var sendNRPN, schedmidi, schedmidicmd;
+				var sendNRPN, schedmidi, schedmidicmd, donecmd;
 				var hasNote = ~n != \none;
 
 				midiout = ~midiout.value;
@@ -60,14 +60,17 @@ DirtEventTypes {
 				} {
 					{|f| thisThread.clock.sched(latency, f)}
 				};
+				donecmd = { |cmd|
+					if (midicmd.notNil and: { midicmd === cmd }) {
+						midicmd = nil
+					}
+				};
 				schedmidicmd = { |cmd|
 					var func;
 					func = Event.default[\midiEventFunctions][cmd];
 					args = func.valueEnvir.asCollection;
 					schedmidi.value { midiout.performList(cmd, args) };
-					if (midicmd.notNil && midicmd === cmd) {
-						midicmd = nil
-					};
+					donecmd.value(cmd);
 				};
 
 				// guess MIDI events from parameters
@@ -92,9 +95,9 @@ DirtEventTypes {
 					});
 				};
 
-				if(~progNum.notNil)   { var num = ~progNum;   schedmidi.value({ midiout.program(chan, num) })};
-				if(~midibend.notNil)  { var val = ~midibend;  schedmidi.value({ midiout.bend(chan, val)    })};
-				if(~miditouch.notNil) { var val = ~miditouch; schedmidi.value({ midiout.touch(chan, val)   })};
+				if(~progNum.notNil)   { var num = ~progNum;   donecmd.value(\program); schedmidi.value({ midiout.program(chan, num) })};
+				if(~midibend.notNil)  { var val = ~midibend;  donecmd.value(\bend);    schedmidi.value({ midiout.bend(chan, val)    })};
+				if(~miditouch.notNil) { var val = ~miditouch; donecmd.value(\touch);   schedmidi.value({ midiout.touch(chan, val)   })};
 
 				if (hasNote) {
 					freq = ~freq.value;