Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge breaks when MySQL's sql_mode is set to some specific values or "Strict Mode" is on #241

Open
yuliu opened this issue Dec 8, 2019 · 2 comments

Comments

@yuliu
Copy link
Member

yuliu commented Dec 8, 2019

PostgreSQL and SQLite may have equivalently so-called strict mode, but I'm not familiar with them.

Quick search:
PostgreSQL: no findings.
SQLite: https://sqlite.org/src/wiki?name=StrictMode

Relevant issue: #235. I can't confirm which setting is in effect here, the setting of sql_mode when I'm experiencing the problem is STRICT_TRANS_TABLES,NO_AUTO_CREATE_USER,NO_ENGINE_SUBSTITUTION.

A community post complains about sql_mode set with only_full_group_by: https://community.mybb.com/thread-225560-post-1339852.html#pid1339852

Seems MySQL is involving more strict modes along new version releases. So some queries may break the merging in newer MySQL versions.

@euantorano
Copy link
Member

I believe PostgreSQL is strict by default basically, an I'm not aware of any options to make it more/less strict. @kawaii may know better though.

@yuliu
Copy link
Member Author

yuliu commented Jul 8, 2020

MySQL strict mode may be disabled by setting sql_mode to some combinations of not strict modes, for example:

SET SESSION sql_mode = 'ANSI,ONLY_FULL_GROUP_BY'

This should be useful for normal users who use the merge system but for merge system's developers doing so may not be recommended IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants