From c2e720c73e8b614b1024fb97a18bb49ca8b3fcb7 Mon Sep 17 00:00:00 2001 From: Jesper Lloyd Date: Fri, 27 Dec 2019 14:04:18 +0100 Subject: [PATCH] Rewrite conditional, remove always-true clause Parameter is unsigned, no need to check that it's >= 0. Closes #132 --- mypaint-brush.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mypaint-brush.c b/mypaint-brush.c index 3488767a..7fb1775c 100755 --- a/mypaint-brush.c +++ b/mypaint-brush.c @@ -1437,7 +1437,7 @@ update_brush_setting_from_json_object(MyPaintBrush *self, { MyPaintBrushSetting setting_id = mypaint_brush_setting_from_cname(setting_name); - if (!(setting_id >= 0 && setting_id < MYPAINT_BRUSH_SETTINGS_COUNT)) { + if (setting_id >= MYPAINT_BRUSH_SETTINGS_COUNT) { fprintf(stderr, "Warning: Unknown setting_id: %d for setting: %s\n", setting_id, setting_name); return FALSE;