Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidebar: Improve <details> state storage data structure. #14

Open
AesaraB opened this issue Feb 14, 2025 · 0 comments
Open

Sidebar: Improve <details> state storage data structure. #14

AesaraB opened this issue Feb 14, 2025 · 0 comments
Labels
cat.Javascript cat.Size.Small

Comments

@AesaraB
Copy link
Contributor

AesaraB commented Feb 14, 2025 •
edited
Loading

We currently store the open/close state of sidebar collapsible menus in local storage discretely:

For each applicable <details> tag we use a variable name prefixing details- to the element ID, and boolean value for its state.

This is kinda stupid. It'd be much more elegant to store these KV pairs in an object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat.Javascript cat.Size.Small
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AesaraB